ElnuDev/hebi

Use .wav audio directly instead of converting to .mp3

Closed this issue · 3 comments

ElnuDev commented

Currently, the .wav files in the dev_assets folder cause errors when used, even with the wav feature of Bevy enabled. See this thread on the Bevy Discord server for more info. The files seem to play fine, so I'm not sure if this is some issue with the encoding of the files that jsfxr outputs, or if there's a potential bug in Bevy. Either way, it'd be way cleaner use the original .wav files directly instead of having to convert them .mp3 using a shell script like is being done currently and store both in this repository.

grtcdr commented

You're going to want to look into rodio which is an abstraction (extension?) over many audio encoders/decoders, namely hound for the WAV format.

ElnuDev commented

There was an issue with jsfxr — one of the community members on the Bevy Discord fixed the issue with this PR, and is now live on the site. Hebi is now using the fixed .wav files directly, but keeping the mp3 feature of Bevy in case the user wants to use .mp3 files.

  • 🎉3
grtcdr commented

Good to hear :)