Error when changing VCL styles. DelphiVCL 1.0.3

Question

Error when changing VCL styles. DelphiVCL 1.0.3

IanC216 opened this issue 2 years ago · 11 comments

This issue has already been raised (issue #50, on March 18th by @fansxs). I started a discussion on the same topic, and @lmbelo asked me to raise it as an issue again.

The ActivityIndicator.py demo crashes when I try to change style. The "__on_load_style_click" function crashes at line:
"valid_style, style_info = self.__sm.IsValidStyle(style_file_path)".
Python (v3.10) returns the error message "TypeError: cannot unpack non-iterable bool object".

Removing the "style_info" variable allows the line to run, but then a different error is raised at the line "self.__sm.LoadFromFile(style_file_path)" :

TypeError: Call "LoadFromFile" returned a value that could not be converted to Python
Error: Unsupported conversion from TValue to Python value

Here is my version of the code:

Answer 1 · 2023-07-13T12:49:33.000Z

@lmbelo Some more information that might be useful to you. When I run activityindicator.py from the console rather than in PyCharm, I get a different error. This appears immediately after choosing a valid folder from the 'Select the VCL Styles directory' dialog.

Answer 2 · 2023-08-06T22:33:44.000Z

Using a freshly compiled pyd from the current version found in Github gives no error any more. And browsing the history of WrapVclThemes.pas gives no clue why it does not work in delphivcl.pyd 1.03.

Answer 3 · 2023-09-06T01:17:56.000Z

@lmbelo Some more information that might be useful to you. When I run activityindicator.py from the console rather than in PyCharm, I get a different error. This appears immediately after choosing a valid folder from the 'Select the VCL Styles directory' dialog.

I believe you were seeing this issue because the console was being freed. Look for the FreeConsole method in your code.

Answer 4 · 2023-09-19T12:49:01.000Z

I must rectify my comment from 07 AUG 2023: a fresh compile of version 1.03 does not work, and also not for the new release version 1.04 (and also not directly from PIP install delphivcl)!

The source code for D4P is found in P4D, and we must note that there are three "official" repositories of P4D:

GetIt repository: old version 1.0, VCL styles works fine.
PyScripter GitHub repository: also works (last commit 02 AUG 2023).
Embarcaderor GitHub repository: fails (last commit 03 SEP 2023).

The source code for WrapVclThemes.pas is the same in PyScripter and Embarcadero, so I am not sure where the problem is.

Answer 5 · 2023-09-20T12:17:37.000Z

@MGBergweiler I'm able to reproduce the issue. I'm working on fixing it.

Answer 6 · 2023-09-20T12:22:36.000Z

@lmbelo I just found out that by disabling $DEFINE EXPOSE_MEMBERS, the method IsValidStyle_Wrapper now does get called, and the problem is gone.

Answer 7 · 2023-09-20T13:41:37.000Z

Right! The statically wrapped method is being overridden by the dynamically exposed method.
I got this fixed. It will be available in next release.

Answer 8 · 2023-09-20T15:06:25.000Z

Thanks for taking the time to address this issue. Any idea when the next release will be available?

…

On Wed, Sep 20, 2023 at 2:41 PM Lucas Moura Belo ***@***.***> wrote: Right! The statically wrapped method is being overridden by the dynamically exposed method. I got this fixed. It will be available in next release. — Reply to this email directly, view it on GitHub <#57 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZ4D5TOKXE2D6XYYXKKBACDX3LXB3ANCNFSM6AAAAAA2HYWC3E> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Answer 9 · 2023-09-21T00:11:25.000Z

@IanC216 we are planning an emergency release for the current week.

Answer 10 · 2023-09-22T21:14:18.000Z

@MGBergweiler and @IanC216, there's a new version available on pypi. Can you confirm it works on this latest version, please?

Answer 11 · 2023-09-23T09:39:51.000Z

Thanks, is working fine here!