`Reflect` derive macro uses wildcard imports
Opened this issue · 1 comments
MarijnS95 commented
Describe the bug
When using #[derive(Reflect)]
inside a workspace where the clippy::wildcard_imports
lint is disallowed, it fails the linter:
error: usage of wildcard import
--> test.rs:75:35
|
75 | #[derive(Component, Clone, Debug, Reflect)]
| ^------
| |
| ___________________________________in this derive macro expansion
| |
76 | | pub struct Foo {
| |___^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports
= note: `-D clippy::wildcard-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::wildcard_imports)]`
= note: this error originates in the derive macro `Reflect` (in Nightly builds, run with -Z macro-backtrace for more info)
Is there any particular reason why these wildcard imports are used, and if so, can they be annotated
with a #[allow]
internally?
davidpdrsn commented
Is there any particular reason why these wildcard imports are used
Makes our lives so much easier. Wildcard imports are good :)
Adding #[allow] is fine. Do you wanna submit a PR perhaps?