Dropbox link crashes the downloader
bathrobehero opened this issue · 10 comments
Hey, great tool! I'm trying to download my library but it always crashes at a game that only has a dropbox link for download.
Traceback (most recent call last):
File "C:\Users*\AppData\Local\Programs\Python\Python38\lib\runpy.py", line 192, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Users*\AppData\Local\Programs\Python\Python38\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\Users*\AppData\Local\Programs\Python\Python38\lib\site-packages\itchio\downloader_main.py", line 26, in
lib.download_library()
File "C:\Users*\AppData\Local\Programs\Python\Python38\lib\site-packages\itchio\library.py", line 32, in download_library
game.download(self.login)
File "C:\Users*\AppData\Local\Programs\Python\Python38\lib\site-packages\itchio\game.py", line 62, in download
itchio.utils.download(url, path, self.name +" - "+file)
File "C:\Users*\AppData\Local\Programs\Python\Python38\lib\site-packages\itchio\utils.py", line 11, in download
filename = re.search(r'filename="(.+)"', cd).group(1)
File "C:\Users*\AppData\Local\Programs\Python\Python38\lib\re.py", line 199, in search
return _compile(pattern, flags).search(string)
TypeError: expected string or bytes-like object
Since there's no way to remove games from the library, could you please add a way to ignore games with dropbox links?
The only workaround I've found is to create a .json file with the name of the game so that the downloader skips it.
I just encountered the same issue. Happened for the "Spell Slingers: Trick or Treat" game. I assume this issue will become more prominent soon as it's a part of the Ukraine support bundle.
@bathrobehero Would you mind sharing more details about your workaround? I'm struggling to get the right content into my jsonfile.
@ThisIsTenou The .json file can be empty, it's just have to exist under the right subfolder and with the right game name.
Oh neat! Thank you.
#9 should fix this once merged
Edit: Answered my own question. 😎
I assume this will also resolve the issue with web games?
https://isoteric-games.itch.io/timebomb-web
Downloading Timebomb - timebomb-web
Traceback (most recent call last):
File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/zageron/.local/lib/python3.9/site-packages/itchio/downloader/__main__.py", line 26, in <module>
lib.download_library()
File "/home/zageron/.local/lib/python3.9/site-packages/itchio/library.py", line 32, in download_library
game.download(self.login)
File "/home/zageron/.local/lib/python3.9/site-packages/itchio/game.py", line 62, in download
itchio.utils.download(url, path, self.name +" - "+file)
File "/home/zageron/.local/lib/python3.9/site-packages/itchio/utils.py", line 11, in download
filename = re.search(r'filename="(.+)"', cd).group(1)
File "/usr/lib/python3.9/re.py", line 201, in search
return _compile(pattern, flags).search(string)
TypeError: expected string or bytes-like object#9 should fix this once merged
Cloning the repo, manually applying the patch in the PR, and then running pip install . from the root of the repo should get in working until the PR is merged. (At leased it worked for me)
I've made my fork with the fix applied public. Feel free to use that one:
pip install git+https://github.com/ThisIsTenou/itchio
I'll merge in the fix in pronto, as yeah, i've just noticed it