[Seeking Opinions/Approval] Unify feature/feat item types
Opened this issue · 3 comments
Some time ago, when discussing #245, I had the idea of unifying the various "feat" items (raceFeats, classFeats, pathFeats, destinyFeats, feat) into a single item that could also accommodate monster/hazard traits. I never heard any replies from fellow devs on that particular idea, so I'm going to bug you all for comment here.
My proposal is that, since they all have near-identical fields and implementation, I would like to collapse these all into a single "feature" item with a type selector for Class/Race/Path/Destiny/Background/Theme/Feat/Trait/Other. Since the classFeats additional parameters seem to be vesitigal 5e organs, the only meaningful difference between any of these items right now is whether they have an associated level and/or class/race/source—so it makes great sense to me to merge them. I would also add a property to denote aura traits (not to automate them, since that's the realm of effects, but rather to display on sheet).
I know this is a bunch of work that's broadly unnecessary, but I also would really like to see it happen. Which is why I'm suggesting I will take it on myself! So, my questions to fellow devs are:
- Are you okay with this, if I'm taking on the work?
- Aside from the obvious (time investment, potential for new bugs, need for mass migration) are there other reasons this is a bad idea?
I thought I had commented on this in the previous thread, I'm good with it.
Sorry I missed this comment. This is actually something that I've wanted to do for a long while now, I've just never gotten around to it.
Aww yes :D This is gonna feel so good.
Now I just gotta find the time! <XD