Eneco/landscaper

Get rid of Release.Version

rollulus opened this issue · 3 comments

rollulus commented

see #58, #66

philipbjorge commented

@rollulus -- Cool if I take this on?

It sounds like we want to remove it, rather than make it optional?

rollulus commented

I'm cool with that, @philipbjorge, thanks 👍

Maybe we should make it optional instead of totally removing it, just in case.

While removing / making it optional, I was considering to get rid of release though, moving chart and the now optional version up one level, e.g.:

name: hello-world
chart: local/hello-world:0.1.0
configuration:
  message: Hello, Landscaped world!

Also, while writing this a random thought: since we are doing backwards incompatible changes anyway, would renaming configuration into values make sense, to align better with Helm's nomenclature? @johnhofman @TommyM

Is that something you'd like to do as well? I'm looking forward to your PR, thanks!

philipbjorge commented

I like the idea of making it optional.
I also like the new landscape definition format and would support updating configuration to values.
Are @johnhofman and @TommyM the primary owners of this repo?

I'd be interested in making those changes. Will get it going over the weekend.