EngFlow/bazel_invocation_analyzer

Cannot find GC thread in newer profiles

saraadams opened this issue · 1 comments

saraadams commented

Description

For more current versions of the Bazel profile, the garbage collector thread is not found.
The CLI prints out:
This does not appear to be a valid Bazel profile. Unable to find garbage collector thread.

Observed behavior

The GC thread is not found.

Expected behavior

The GC thread is found.

Step-by-step guide on how to reproduce the bug

  1. Try to anayze a profile generated by a more recent Bazel version, e.g. I was able to reproduce this with 7.0.0.

Additional context

It seems the GC events are now in a thread named "Notification Thread".
We could update the code to look for that thread - or ignore the thread name and simply look for entries that have the category gc notification. The latter might be better, as I have also seen valid Bazel profiles that include no GC / notification thread.