Incorrect Padding
flamendless opened this issue · 7 comments
Free-tex-packer:
here you can see a padding of 4 per quad, so total would be 8 for neighboring quads
Export-TextureAtlas:
here you can see a padding of 4 per quad but is shared between neighboring quads so resulting to only 2 pixels per quad
This is expected behaviour, but I can understand why it shouldn't be. CSS padding puts it around each object whilst the code defines padding as spacing between each object. Unsure if the solution should be to rename the variable, or change the behaviour
Either:
- just multiply the padding by two internally?
- have a note or comment in the readme about the behavior of padding?
I'll change it. I'll have spacing to do the current behaviour, whilst padding will add spacing around an object (currently the atlas fits closely to the edge of the texture, but padding will force a gap between the edge and the quad)
Awesome. spacing and padding sound perfect.
(currently the atlas fits closely to the edge of the texture, but padding will force a gap between the edge and the quad)
indeed, in free-tex-packer, setting padding will also add padding in the edges of the atlas
Just an info, im using padding in combination with an outlining shader (though mine is heavily modified) for my project
I tested the latest commit 1b2171bb45f637d2ad154f9387931993791325a3 the padding works but the data is not correct.
The x and y of the quad should use (4, 4) lets say instead of (0, 0) if padding is 4.
Good to know. Github died last night for a couple of hours just as I was pulling, so I wasn't able to work too much on it
This should be fixed with 133d8e886101a4ae700b6514afe3b198d67f270a now. It was only an issue with dynamic atlases. Reopen if you find fault with it