EnixCoda/Gitako

Memory leak in large pull requests

333fred opened this issue · 2 comments

333fred commented

When I open dotnet/roslyn#61565 or other similarly-sized PRs with this extension enabled, I see memory usage in the tab increase both quickly and regularly, at a rate of ~5 MB/sec (in approximately 5 second bursts), until the tab is eventually killed due to out of memory issues. When I disable Gitako, the leak goes away and the memory usage of the tab is stable.

EnixCoda commented

Thanks, @333fred

After a quick investigation, the reason is that Gitako would query PR file list endlessly because of unexpected responses from GitHub.

I'll release a patch for the issue soon.

  • 👍1
EnixCoda commented

Fixed in v3.7.1, now Gitako can load PRs even 10x larger than dotnet/roslyn#61565 , e.g. dotnet/roslyn#61070