EnixCoda/Gitako

`pinned` icon style

thilllon opened this issue · 1 comments

thilllon commented

Hi,
Thanks for the amazing extension.

I think it looks better if the pinned icon style would be changed when it is activated

Before:

outlined style

image

After(expected):

filled style

image

EnixCoda commented

Thanks, @thilllon

Yes, it does look better that way, with higher contrast so that users can tell the status easier.

Reasons it is not in filled style:

  • The most important reason: Gitako's icon are from Octoicons, which does not offer an filled version for the pin icon.
  • Apart from its slight color change. Currently users can tell the status from the existence of the collapse icon next to it.
  • It is easy to tell if the panel is pinned without even looking at the icon. Because when it is not pinned, Gitako would be collapsed before mouse hovers. Otherwise, it is apparently pinned.

Anyway, I will be happy to apply the filled style pin icon once it is available!

  • 👍1