Eomys/pyleecan

[CO] Rework csv file template

Closed this issue · 0 comments

Hello all,

I finally have more time to dedicate to pyleecan and my current objectif is to clean/improve pyleecan. Before the next release, I would like to do the following (I think we already talked about this proposal but I don't remember where):
The current csv template is composed of two tables, one for the properties and one for the methods (and other information about the class) that are completely independent. The issue is that, as the tables are side by side, when committing/merging with git, the modifications are handled line by line and it creates unnecessary conflict between the two tables. We plan to move the "Methods table" bellow the "Properties table". That way no more unnecessary line conflict. There is already a function to move the tables: https://github.com/Eomys/pyleecan/blob/master/pyleecan/Generator/Functions/move_table_script.py. I still need to update the read csv part of the class generator to be able to handle both cases (side by side or in column). As the "read csv" is separated from the generation part it should not be that hard.

What do you think about this proposal ?

Best regards,
Pierre