Design suggestion
NeilGirdhar opened this issue · 1 comments
NeilGirdhar commented
I'm just starting to use Orion. Looks like a very useful tool! One suggestion: Consider having Space
depend on sorteddictionary
, and use composition over inheritance.
(Also, Python dictionaries are ordered, so you ordering by name might not be that important if all you want is for the ordering to be consistent between runs.)
bouthilx commented
Thanks for the suggestion! The names were indeed sorted as a simple solution to keep ordering consistent between runs for python <=3.5. Now that we do not support 3.5 we could indeed remove this. I'm happy to help if you'd be interested in making a PR. :)