EricLBuehler/candle-lora

Is config.rank <= 0 ever true?

def-roth opened this issue · 1 comments

I can't see any case where the rank can be negative for Tensor multiplication as for 0 that would be equal to drop everything before. Please correct me.

@def-roth yes the rank should never be negative. We should probably use NonZeroUsize.