Toggling “CodeChecker: Show full command line show” results in toggling of output terminal (switching between codechecker’s and the first one on the list of terminals),

Toggling “CodeChecker: Show full command line show” results in toggling of output terminal (switching between codechecker’s and the first one on the list of terminals), expected behavior is to put Codechecker output terminal “on top”. The same happens when clicking on the bottom but on “CodeChecker: analysis finished”, behavior is the same

this was reproducible with (Theia 1.21.0)

maybe this is a theia specific issue.

This problem can be reproduced only when using Theia editor the same way as you described.

Looking at the source code the problem comes from this part:

CodecheckerVSCodePlugin/src/editor/logger.ts

Lines 19 to 22 in e4eb7bf

    
           showOutputTab() { 
        
               this.window.hide(); 
        
               this.window.show(false); 
        
           }

@Discookie Why do we need to call the this.window.hide() function here? Without that line it work properly.

Originally it's there, because hiding and re-showing the window resets the auto-scroll state. The user toggling it would want to see the newest logs, and not where they last stopped scrolling with autoscroll off. I believe it can be safely removed if it's buggy with Theia though.

But overall I'm not a fan of showing the full command line on the output logs tab, especially if the terminal doesn't auto-scroll to the bottom. It would be better to create a separate read-only Terminal or similar to show it.

	showOutputTab() {
	this.window.hide();
	this.window.show(false);
	}