remindme command could be run by anyone
dongle-the-gadget opened this issue · 2 comments
dongle-the-gadget commented
In ModCmds.cs I saw that the Remind command has [RequireHomeServerPerm(ServerPermLevel.Tier4, WorkOutside = true)]. The confusing thing here is that if WorkOutside equals true, the permission test would pass, making the RequireHomeServerPerm relatively useless.
Can you give me an explanation on how WorkOutside should work?
Erisa commented
The WorkOutside is supposed to allow the command to work outside of the home server (For example in DMs)
I've now fixed the immediate issue of it resulting in the permissions not being respected. It will still be usable by everyone in DMs for now, which I will strive to fix later.
Erisa commented
All done now, permissions will be respected correctly regardlesss of where you use the command.
