Esri/crowdsource-manager

Crowdsource manager is not working with new map viewer map after adding a layer.

Closed this issue · 8 comments

The user has an old CS Manager app, recently they added a new layer using new map viewer, saved it and the app does not load any more, I see a console error.
Test app: https://ess.maps.arcgis.com/apps/CrowdsourceManager/index.html?appid=2aec901e916a4868b4ecb19b5924494c

image

@sumitzarkar could you please take a look at this issue and assess the LOE?

@aparveen

We have analyzed this issue and here are our findings:

  • In Webmap settings, if the search is enabled and some layers are added for search, then in CSM when a layer is selected and if it is added for search in webmap then the search box will be displayed in the header as shown in the below screenshot
    image
  • So The CSM app checks if search is enable by chechink application properties from webmap itemInfo (this.itemInfo.itemData.applicationProperties.viewing.search.enabled)
  • If the search is enabled we try to acess the layers(array of layers) property form search object(this.itemInfo.itemData.applicationProperties.viewing.search.layers)
  • We observed that when a search is enabled on any **layer ** in the webmap, and if that layer is deleted from the New Map viewer then the Search property is still enabled but the layers array becomes undefined
  • As discussed on the call we will add the check to see if the layers array is valid or not in CSM. However, we think this needs to be handled in Map Viewer also so as to avoid any issues in other applications.

We have fixed this issue and we will deliver it in the next code drop.

@sumitzarkar @sandhyakurumanale-ct I am seeing the same issue after adding a new layer (search is not enabled) which is not shared to the group. After sharing the layer to the group it works as expected, my expectation was if I add a layer that is not part of the group, Manager will only show the layer that is shared and not become unresponsive.
Test app: https://stategovernment.maps.arcgis.com/apps/CrowdsourceManager/index.html?appid=e064623afe294dcd93c3be1f68b21ebf

@aparveen

Dev Checklist

Items ​ Is required​ Status Comments​
Required NLS change?​ No  
Required Backward compatibility​? No    
Required 508​? No  
Need Sanitize?​ No  

Impact Analysis Report

Impacted Areas Comments
Have Configuration changes?​ No
Have Runtime changes?​ Yes
Impact on RTL No
Runtime changes 1.In Web map settings, if the search is enabled and some layers are added for search then the application should be loaded successfully after deleting the search layers in the new map viewer
2.In Web map settings if the search is disabled which was previously enabled, the application should be loaded successfully after adding the new layers in the new map viewer

@sumitzarkar I am seeing the same error in QA, test app: https://sg-em-qaext.mapsqa.arcgis.com/home/item.html?id=c44da620405040619990f4119a4514a7
Test map: https://sg-em-qaext.mapsqa.arcgis.com/home/item.html?id=564bc312fe564b2c857110f78151e5d2
I deployed the Special Event Permit and Operations solution, open the special permit map, add a layer that is not part of the group and popup is enabled for the added layer saved it but the won't load and I am seeing the same console error.

@aparveen

The above mentioned issue is same as #344 (comment)

As discussed on the last call please let us know if this needs to be addressed in 10.2 release

Verified in QA