Esri/solutions-grg-widget

GRG from Area by Dimension - disable cell x and y dimension text boxes until dynamic extent is drawn on map

Dbarnes1 opened this issue · 8 comments

Bug or Enhancement

Currently, the workflow when creating a GRG from Area by Dimension may be confusing, as users should always use the interactive draw tools (polygon and rectangle icons) to draw an extent on the map first. However, the text boxes for defining cell size (x) and (y) are not disabled, meaning users could first type values into the text box. Once they draw the area, their values for cell size change.

The resolution to this is to disable the cell size text boxes until the user draws the dynamic extent/preview on the map.

Screenshots:
image

these should be grayed out.

Addressed in PR #101

@adgiles and @elinz take a look at my review of this PR and you can see the toggle functionality creates a loophole in our attempt to make users draw a preview extent before entering values, this should be addressed before merging and verifying: #101 (review)

I'm going to push this back to in progress

@Dbarnes1 we cannot disable the toggle till the extent has been drawn as code needs to know how many columns and rows are required to update the cell width and height. We can fix this by not automatically enabling the height and width when the toggle is put back to off

@adgiles good catch, that fix makes sense to me

I'll look at this first thing tomorrow

sounds good, thanks a lot!

Updates made to existing PR #101

@adgiles this has been fixed, closing