Define by reference system (area and point) widget tools do not check if input area falls into polar region
elinz opened this issue · 8 comments
Bug or Enhancement
The define by reference system both area and point tools do not check if the input area is located in the MGRS polar regions (i.e. north of 84N degrees; south of 80S degrees). When the user clicks "Create GRG", no error message is displayed to inform the user why the output GRG was created.
Repo Steps or Enhancement details
I would expect the widget tools to check if the input is in or crosses into the MGRS polar regions and display an error informing that the input area is invalid. With the current behavior, users won't understand the reason why the GRG was not created.
@nfeuerstein @lfunkhouser @joebayles I've labeled this with "sprint backlog" so we can address this through documentation as a "Known Issue" and add the check and error message at another release. Thoughts?
Screenshots
Documented
Per PE discussion, no Doc changes needed.
Found an issue with this during retro, reopening
The original fix for this issue had a slight bug that was affecting the create Point GRG by Reference System. If the user tried to create a point GRG within a polar region with a Grid Size that was not Grid Zone the GRG would not be created and no warning was given.
On investigation if the grid origin point was in a polar region the mgrs.USNGtoPoint() function returns a point that has NaN values for its x and y. Added a check to exit the function with a warning message if this occurs.
Update to this issue in PR #139
@kgonzago has approved and merged the PR so good to QA
This is what I have as a result from working in the polar region. I feel like this is verified. Please advise if this is not what we would expect.
