Esri/solutions-grg-widget

Refactor code base

kgonzago opened this issue · 7 comments

kgonzago commented

Before the GRG widget can be added to the WAB code base to have it included in the pool of core widgets for 6.1 release, we will need to review the widget from code and UI perspectives. Below is a list of high-level topics that will guide this epic:

  • The code base will need to be refactored before its inclusion into core WAB. This is captured in #131 and #138.

  • We want to promote code readability and also adhere to best practices for JS coding (coding guidelines from JS Dev Team). This is captured in #136.

  • Review UI and determine if it adheres to WAB design guidelines. This is captured in #137.

lfunkhouser commented

@kgonzago please provide more information on what this means.

kgonzago commented

@lfunkhouser @topowright, I added additional information to this epic and tied four issues to it. Hopefully, what I added will be sufficient to remove any confusion. Let me know if more info is needed.

@adgiles Please add to this epic if I missed something.

topowright-zz commented

@adgiles is this still needed being that we are now further along in the process?

adgiles commented

@topowright no refactoring of the code base has taken place

kgonzago commented

Looks like it is not needed since Junshan already completed his initial code review without a comment regarding code refactoring.

kgonzago commented

We can close out this epic or temporarily place it on the back burner.

lfunkhouser commented

Closing. Will create a new issue/epic if this is required.