Clip Grid to GRG Area toggle options are reversed
lfunkhouser opened this issue · 6 comments
Issue reported by @MikeTschudi
Bug or Enhancement
The Clip Grid to GRG Area toggle positions for "on" and "off" are reversed in the UI.
Repo Steps or Enhancement details
- Open GRG widget
- Select Define a Grid from an Area
- Select By Reference System
- Note the Clip Grid to GRG Area toggle button.
The user slides the toggle right (red) to disable the option to clip grid to GRG area and slides it left (green) to enable the option to clip grid to GRG area.
Screenshots
The standard for iOS-style toggles is slide right to get it on/enable/green and left to get it off/disable/red.
Version found:
GRG January 2018
WAB 2.7
This is the same toggle that is used across all widgets within Web AppBuilder
@MikeTschudi I agree with you that it is confusing since UI guidelines for toggles are on/right and off/left. Do you have examples of specific widgets that follow this design?
We followed the pattern of other widgets and are consistent with widgets like the "Add Data" widget, for example:
I found the toggle in AddData & GridOverlay, and as @adgiles pointed out, their behavior is the same as GRG.
@Jianxia, this toggle seems confusing in AddData & GridOverlay as well. With GridOverlay, it's not so bad because one can just re-open the widget and change the toggle, but for AddData, it's a lot less clear.
AddData:
GridOverlay off state (i.e., grid is not displayed when widget is closed):
@lfunkhouser, I only did a cursory check of a dozen widgets, but didn't find additional slide toggles; checkboxes are more common.
While the slide toggle usage is clearly consistent within WAB, we are adding friction to the UI by bucking long-held convention outside of the WAB.
In addition to the iOS example above,
Windows
(MacOS, on the other hand seems to have moved to checkboxes: "Use a checkbox instead of a button when the user needs to choose between two states. The on and off states of a checkbox are generally clearer to most users than a push button that's configured as a toggle.")
Google Chrome settings
off/disabled and on/enabled
An exception:
Addressed in PR #155.
No documentation change required. Just needs to be verified and moved up to devtopia
This has been verified and pushed into devtopia