Esri/solutions-grg-widget

GRG configuration page Lock Settings toggle switch

dfoll opened this issue · 3 comments

dfoll commented

Bug or Enhancement

The Lock Settings toggle positions for "on" and "off" are reversed in the configuration.

Repo Steps or Enhancement details

  1. Add GRG widget to an app
  2. Click the configure this widget button to open the widget configuration
  3. Note the Lock Settings toggle switch

Screenshots

adgiles commented

Addressed in PR #158

  • 👍1
dfoll commented

I got this into devtopia and requested another code review on all the stuff from the past week. https://devtopia.esri.com/WebGIS/arcgis-webappbuilder/pull/11651 if anyone wants to give it a look and make sure it's all good

@adgiles @kgonzago

kgonzago commented

@dfoll Looks like string issues still need to be addressed based on Junshan's last response to your commit.