Esri/squad-leader-android

Add option to turn off labels

Opened this issue · 8 comments

Labels are displayed for all position reports. Give the user the option to turn labels on and off if possible.

@dfoll , could you please check this? I implemented it.

Just a gentle reminder (for a nice to have), if you do make a commit, pull request, etc. that addresses an issue, don't forget to put the issue number in it so it shows up in this feed.

Also @dfoll a reminder about our new 1-week rule for getting things tested before Gary can just close automatically (And you have to open a new issue)

...but make sure you don't put the word "fixes" in front of the issue number, because that would close it, which the tester is supposed to do.

Interesting - I did not know about that behavior - thanks for the tip, esp. since "Fixes Issue XXX" is exactly the phrase I would have used if I didn't know this quirk

Time's up. I'm closing this.

sorry about this....
i tested this a while ago and everything looked ok... i thought i had closed it, guess i did not close in the proper place

This isn't working. I will address it before release.

This broke in 10.2.3 or 10.2.4. The bug is NIM102986. I will comment out the pause labeling button for now. There's nothing else reasonable we can do, unless we rewrite the 2525C DictionaryRenderer, which wouldn't be reasonable.