Esri/terraformer

GeoJSON Coordinate Validation

Closed this issue · 2 comments

Hello, Thank you for writing this! Its great!
I needed to have good geoJSON coordinate validation so I ended up writing a geoJSON Validation Lib. I validate before I feed my JSON into Terraformer. But it might make sense to integrate validation and do the checks on the creation of the primitives. I don't think it would be too hard to add my library into the mix. If this is a route you think would make sense for you, would there be any interest in a PR?

This looks great! I wouldn't say no to a pull request.

But there a couple of things I would like to see in a PR.

  1. Tests. It looks like you already wrote a bunch of Jasmine tests so this wont be to much of a problem. See our spec folder https://github.com/Esri/Terraformer/tree/master/spec for how we are setting these up.
  2. Should work in Node, Browsers and with AMD loaders. You can copy our boilerplate https://github.com/Esri/Terraformer/blob/master/src/terraformer.js#L1-L18
  3. Should work in IE 8. I see some things that won't work in IE 8 like forEach https://github.com/craveprogramminginc/GeoJSON-Validation/blob/master/index.js#L234

I think we should also decide weather this would work better integrated into the core or as a separate module? @JerrySievert what do you think?

If you want to issue an initial PR we can all work on this.

closing, but always happy to revisit.