Esshahn/spritemate

Sprites are not renamed when duplicated; export reflects this also

dagershman opened this issue · 6 comments

I created a single multi-color sprite and duplicated it several times to alter as needed. As I hover over each sprite, the name is still "sprite_0":

sprite_0x4.mp4

When I save the file to any of the Assembler options, all the labels reflect this as well:

pic

Thank you for the issue report - and great sprites by the way, love them!
I will look into this once I got more time. Or better, submit a PR if you can.

I would submit a PR, but I'm not a Javascript coder so I'd probably do more damage than good. :) I'll happily wait for the pro!

Let's wait for the pro then :D (I consider myself a noob also haha)

@dagershman, note that the file comments iterate the sprites by numbers

// sprite_0

whereas the sprite name could be any string, e.g.

penguin_left_one

I assumed that when generating a copy of a sprite, it would be manually renamed (like when generating a copy of a file in a OS). However, operating systems add suffixes to copied files, like

penguin_left_one_copy(1)

Do you consider this useful to implement (would be a quick change)?
I'm leaning towards less use, as probably few devs would not want to change the sprite name to something more meaningful, e.g.

penguin_left_two

Would appreciate your thoughts.
Cheers!

I ran into this also, all sprites have the same label, even though the comment "increases" the numbering:

// sprite 1 / singlecolor / color: $01
sprite_0:
.byte $00,$00,$00,$00,$00,$00,$1c,$00
(truncated)

// sprite 2 / singlecolor / color: $01
sprite_0:
.byte $00,$00,$00,$00,$00,$00,$1c,$00

Of course KickAss has issues with duplicated labels, even if I don't really (in my one particular case) need anything else than the first label.

Hey @icepic , any chance for a PR from you? I have mostly stopped working on Spritemate due to other obligations, but I'm happy to review the changes if you'd want to submit something.