ExLibrisGroup/primo-explore-devenv

chore(update npm/node): Update recommended software versions and dependencies

Closed this issue · 3 comments

atla5 commented

Background

  • the versions of node and npm specified in the README (#12) are v6.9.2 and 3.3.12 respectively
  • the @latest versions of those are v12.4.0 and 6.9.2, respectively (!!), and neither are being supported anymore
  • an npm audit turns up 74 vulnerabilities, 60 of which can likely be solved by running npm audit fix
  • it looks like PR #103 addresses these concerns

Desired Changes

  • ensure that the devenv works on at least node version 10.16.0 (LTS EOL 2021) and npm version 6.X (npm LTS policy)
  • run $npm audit fix and run tests to ensure there aren't any regressions
  • update the README to reference the (earliest and) most recent versions of npm and node the devenv supports
atla5 commented

note, related: #103 #12

etgrieco commented

@atla5 Thank you!

  • 👍1
NoamaExl commented

closing as PR are merged