Excel-DNA/ExcelDna

Set launch settings in Rider

Myaukolka opened this issue · 0 comments

While building under JetBrains Rider with both <RunExcelDnaSetDebuggerOptions> and <RunExcelDnaSetDebuggerOptionsOutsideVisualStudio> set to true, no launchSettings.json file is being created on build.
This is caused by a condition of ExcelDnaSetLaunchSettings task in ExcelDna.AddIn.targets, where it is never run if BuildingByReSharper property is set to true (which is the case for Rider). While this condition is correct for ExcelDnaSetDebuggerOptions task to never try to set Visual Studio debugger options using Rider, ExcelDnaSetLaunchSettings task should be run with respect to
<RunExcelDnaSetDebuggerOptions> and <RunExcelDnaSetDebuggerOptionsOutsideVisualStudio> properties.

Condition in question:
https://github.com/Excel-DNA/ExcelDna/blob/65693386abdda677668b934ff86f66df6eef5fef/Package/ExcelDna.AddIn/build/ExcelDna.AddIn.targets#L122C6-L122C6