Exeu/Amazon-ECS-PHP-Library

Inconsisten function optional parameters

Opened this issue · 2 comments

The function optional parameters clears the other parameters set already. This is inconsistent because with your ways of returning the main object in all the funcions. (Sorry my bad english).

I think you should either return a new object and make this function static like a Fcatory function. Or just make this function override and concate the parameters passed.

Exeu commented

which function are you talking about?

public function optionalParameters($params = null)