Change Public to Open

[gwsounddsg]

This is a feature request.

Currently the upper level classes (eg: OSCClient) are declared as public, and it would be great if they were declared open. Because this library is mostly about networking, it's difficult to write unit tests without being able to write mocks for these classes. But I understand not wanting people to subclass these classes. Another compromise would be to supply mock classes directly in the library, then you retain your access control

I'd be happy to do the work on this either way and submit a pull request if you think this makes sense.

Thanks,
GW

[devinroth]

Sure works for me. Go for it. Thanks.

…

On Jan 15, 2020, at 6:01 AM, GW ***@***.***> wrote:  This is a feature request. Currently the upper level classes (eg: OSCClient) are declared as public, and it would be great if they were declared open. Because this library is mostly about networking, it's difficult to write unit tests without being able to write mocks for these classes. But I understand not wanting people to subclass these classes. Another compromise would be to supply mock classes directly in the library, then you retain your access control I'd be happy to do the work on this either way and submit a pull request if you think this makes sense. Thanks, GW — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.