ExpediaGroup/pitchfork

enabling HTTPS for the API end point

koushik9951 opened this issue · 5 comments

I am trying to enable HTTPS (ssl), but it's failing , is their any functionality to enable it?

Hi @koushik9951 👋

Can you explain what you are trying to do and in what setup?

Typically ssl management would be done a layer above, by a service mesh, proxy or load balancer.
Do you want Pitchfork itself to use a cert and serve https itself? Please add as much detail as you can to your reply.

@worldtiki : Thanks for your response ,i am want enable HTTPS(by passing a certs) PITCHFORK itslef , so that Pitchfork API us as HTTPS

this is what i tried to enable HTTPS by adding below properties in **application.yml ** file , but I am getting certificate unkown exception while posting traces
server:
port: 9411
ssl:
key-store-password: changeit
key-store: ssl-server.jks
key-password: changeit
key-store-type: JKS
enabled: true
security:
require-ssl: true

That looks ok.

I tried to reproduce the error and couldn't. I pushed a branch to my fork here, with a self-signed cert: https://github.com/worldtiki/pitchfork/blob/ssl_test/src/main/resources/application.yml#L6-L11

(I don't have the require-ssl because I didn't add spring security).

Do you mind trying this branch?
I wonder if the issue is with the location of your jks file.

@koushik9951 I'm going to close this issue. If you need help just comment and I'll reopen it.