Expensify/react-native-qrcode-svg

Logo not accepting external styles

Closed this issue · 3 comments

praveenkumar-kalidass commented

Hi,

We want rectangular logo inside QR image. But the QRCode component is accepting only logoSize as prop, which sets both width and height of the same.

Our solution needs,

  • Either accepting external styles for logo
  • Or accepting both width and height for logo as props

Thanks.

awesomejerry commented

Hi, sorry for the late reply. Do you want something like this #85 ?

You can pass logoSize as an object

<QRCode
  logoSize={{width: 100, height: 80}}
/>
  • 👍1
praveenkumar-kalidass commented

Yes, this will help. If you can accept external styles for logo, that will solve many problems for the same.

awesomejerry commented

It seems that it's not a needed feature. So I'm going to close this issue for now. Feel free to re-open it.