Eyal-Shalev/docopt.js

support node v10.x

Closed this issue · 4 comments

binyamin commented

First, great project. To be honest, I haven't used it yet, but I think it's a wonderful concept.

In the readme, the supported nodejs version is >=12.16.0. While most people probably use the most recent LTS, node v10 is still officially supported by the Node.js working group (https://github.com/nodejs/Release). I would recommend dropping support down to v10.x.

binyamin commented

Some more things 😁

  • maybe publish on npm?
  • is this library typescript-only?
Eyal-Shalev commented

  • It only supports node >= 12.16.0 because that is when they added support for the import statement.
    Which I wanted to use because, I also want to support deno.

  • maybe publish on npm?
    This is an implementation of docopt and the plan is to publish it on NPM after it is moved under the docopt organization.

    Note: If I'll see that this is not going to happen, then I'll probably publish it under my own name and add a mention to the original author.

  • is this library typescript-only?
    I started writing in typescript, but they caused me some headaches with their import system (they don't allow file extensions, and when compiling the code they don't add the correct file extensions either - it's a mess).
    So I ended up writing with the latest features of ECMA Script.

Finally, thanks for the interest and I hope that this library will serve you nicely 😀

Eyal-Shalev commented

@b3u

After further considerations, I re-added typescript support with CommonJS (node 10) support, alongside ES-modules support.
If you want, I could add you as reviewer for it.

https://github.com/Eyal-Shalev/docopt.js/tree/typescript

Eyal-Shalev commented

Done