Add a way to set custom completition and keep 'keyWordCompleter' and 'snippetCompleter'

Question

Add a way to set custom completition and keep 'keyWordCompleter' and 'snippetCompleter'

danijelz opened this issue 3 years ago · 8 comments

Currently the use of custom auto completion removes the 'keyWordCompleter' and 'snippetCompleter' from completers array and only 'staticWordCompleter' is used (lit-ace.js). Would it be possible to add another parameter to 'setCustomAutoCompletion' methods by which users can decide to keep the 'keyWordCompleter' and 'snippetCompleter' or maybe add methods like 'addCustomAutoCompletion' which would keep the 'keyWordCompleter' and 'snippetCompleter' and add the custom one?

Answer 1 · 2021-04-12T10:16:22.000Z

Hello Danijelz,

my solution for this feature request would be:

add a boolean parameter to addCustomAutoCompletion() for keeping the snippetCompleter and staticWordCompleter

Would that fit your request?

David

Answer 2 · 2021-04-12T12:08:54.000Z

That would be perfect. Thanks for fast reply.

Answer 3 · 2021-04-13T20:28:28.000Z

this commit has been reverted!

i'm still working on those changes

Answer 4 · 2021-04-14T06:53:35.000Z

I think I will release the customAutoCompletion changes later today, and investigate #3 later on.

Answer 5 · 2021-04-14T07:53:32.000Z

one short question @danijelz

what version are you using? latest (1.1.0) or 1.0.1 ? just curious

Answer 6 · 2021-04-14T09:20:53.000Z

I'm using 1.0.1 but i'll switch to 1.1.0 right now and let you know how it works...

EDIT:

Looks like it works the same.

Answer 7 · 2021-04-14T11:08:32.000Z

the customAutoCompletion Changes will be implemented in v1.1.1 (if you mean that).

Answer 8 · 2021-05-03T11:02:10.000Z

I tested and closed issue. Works perfectly.