F0x1d/LogFox

[FR] Black theme or fully dynamic BG color like in earlier versions (≤1.5.2)

Closed this issue · 10 comments

Hello, please, add an option to enable Black theme in LogFox.

Alternatively, if possible, you can make Monet theming like it was in the previous version (version 1.5.2 and earlier), i.e. fully dynamic – due to questionable changes in material3 compose, background color is no longer dynamic (you can't make it darker/lighter/completely black with the use of apps like "Repainter" anymore), some app developers ignore this change, still allowing user to fully customize the Monet theme in their app.

Here's screenshots comparing LogFox v1.5.2 and v1.5.3 with "Repainter" enabled:
Screenshot_20231222-152031_LogFox~3


Screenshot_20231222-152406_LogFox~2

Anyway, good luck to you and thank you for your app

Hello, what app did you use to achieve dynamic colors?

Hello, what app did you use to achieve dynamic colors?

Hello. It's "Repainter" (https://play.google.com/store/apps/details?id=dev.kdrag0n.dyntheme).
There also several other apps that allows Monet theming customization, like "Colorblendr" (https://github.com/Mahmud0808/ColorBlendr).
Also, such customizations often included into many Android >12 custom ROMs

Hello, what app did you use to achieve dynamic colors?

Hello. It's "Repainter" (https://play.google.com/store/apps/details?id=dev.kdrag0n.dyntheme).
There also several other apps that allows Monet theming customization, like "Colorblendr" (https://github.com/Mahmud0808/ColorBlendr).
Also, such customizations often included into many Android >12 custom ROMs

thank you.

Screenshot_2023-12-25-23-29-50-865_com.miui.home.jpg
Screenshot_2023-12-25-23-29-57-937_com.dede.android_eggs.jpg
Screenshot_2023-12-25-23-34-26-150_com.f0x1d.logfox.jpg
Many of the dark natural colors in the latest material components v1.11 are based on N2 600 color. However, the black background of the xposed module is achieved by modifying 1000 colors, which can cause this bug.

@Jesse205 I'm now using Repainter, not Colorblendr (it's still in the active development), so can't really tell how Colorblendr handles background color brightness, but afaik on the third tab in Colorblendr there's a separate option to enable Pitch Black theme – just in case, you've enabled it, right?

In general, as far as I understand, it's just updated material components are at fault here (looks like backgrounds can change it's tint, but no longer it's brightness). At least with Repainter, using older versions of the apps (like older versions of Google apps from early to mid 2023), it allows you to customize their backgrounds however you like.

Just in case, here's color pallette comparison with Pitch Black enabled in Repainter and default background brightness:
Screenshot_20231226-002205_Default BG~2
Screenshot_20231226-002205_Black BG~2

I've created a pr which adds a black themed switch within the app.

Also, I think the xposed modules need to implement the ability to tamper with android:lStar in color resources to make sure MaterialComponent v1.11+ works.

Solving the failure issue through LogFox itself is also very simple, just continue to use colorSurface+colorPrimary+elevation to calculate the color. However, it requires rewriting a bunch of widget themes above v1.11, and this approach has been discontinued.

Unfortunately, the maintainer does not want to implement this feature. You can download https://github.com/Jesse205/LogFox/actions/runs/7348124779, this version implements the black mode
You can view the source code here: https://github.com/Jesse205/LogFox/tree/feat_black_theme

@Jesse205 Thank you very much for your efforts

Also, I think the xposed modules need to implement the ability to tamper with android:lStar in color resources to make sure MaterialComponent v1.11+ works.

It would be great if you could share your insights with Mahmud0808, the dev behind Colorblendr, if it's not too distracting for you, of course

@Jesse205 Thank you very much for your efforts

Also, I think the xposed modules need to implement the ability to tamper with android:lStar in color resources to make sure MaterialComponent v1.11+ works.

It would be great if you could share your insights with Mahmud0808, the dev behind Colorblendr, if it's not too distracting for you, of course

You can reach him here: https://github.com/Mahmud0808/ColorBlendr/issues , and the developer can see what's here. I have created an issue

I guess it can be closed? The new ColorBlendr version is released