FAlthausen/Vollkorn-Typeface

Change ttf filenames for Semibold styles

m4rc1e opened this issue · 8 comments

Hey,

Vollkorn-Semibold.ttf should be renamed to Vollkorn-SemiBold.ttf (same capitalisation should be done to the Italic variant)

For the font's nametables, 'Bold' is already capitalised (this is correct).

screen shot 2018-02-12 at 16 18 02

btw, I tried PRing this family earlier. This naming issue stopped the Roman from going. However, I did manage to get the SC variant up. There are a few small issues which we can discuss later this week.

m4rc1e/fonts#13

I will fix that.
And I found another issue with the kerning …
I’ll give you a hint.

@FAlthausen any updates on this? :)

Done. I committed an updated version (4.102) with several fixes and additions.
I think Vollkorn could now be turned further by you, @m4rc1e

Closing as names have been updated.

Unfortunately, this has regressed. Semibold is now back :-).

That’s weird …
When you look into the files, everything should be OK.
Only the file’s name seem to be wrong in the repo. But on my computer, they are OK.
Does that mean that GitHub-Desktop doesn’t work right on syncing?!

bildschirmfoto 2018-04-24 um 10 23 uhr

But GitHub-Desktop says “No uncommitted changes”.
How can I force updating the file names?
bildschirmfoto 2018-04-24 um 10 30 uhr

I fixed it with two commits. Is everything OK now?