Ready for push

Question

Ready for push

Closed this issue 7 years ago · 24 comments

@m4rc1e this repo is now ready to be prepped and pushed.

Answer 1 · 2017-03-03T07:37:37.000Z

What does that mean? These googlefonts processes are a bit in disguise …
(The source files are not 100% ready. There are some small thing to adjust for the special SC instances.)

Answer 2 · 2017-03-03T14:05:35.000Z

No problem if sources are not 100% ready. Just ping here when you are ready for this be live. In the mean time the checks can be done.

The process consists of

step 1. Font preparation ('prepping') — we run a set of glyphs app scripts
https://github.com/m4rc1e/mf-glyphs-scripts/tree/master/QA

step 2. Fontbakery

step 3. Upload the fonts here and check for regression issues. The new font would be compared to the existing one on the live server.

You will be notified here if a design issue is found and asked to fix it.

Answer 3 · 2017-03-03T14:11:57.000Z

Thanks @alexeiva !
An associated question: When you, Alexei, worked on my source files the first time, you added several custom parameters on vertical metrics. What is the base for that? Is there a vertical metrics google standard? Or even a script?

Answer 4 · 2017-03-07T12:48:38.000Z

@FAlthausen I've written one up recently

Answer 5 · 2017-03-09T21:21:51.000Z

@m4rc1e
I uploaded source files with corrected vertical metrics. I hope they fit GF’s rules now.
(Now, the final issue for me is the setup of the SmallCaps instances. Glyphsapp’s Rename-Glyph parameter is currently under construction I need to wait for Georg, which usually doesn’t take long.)

Answer 6 · 2017-03-16T09:28:31.000Z

@m4rc1e
Who will generate the final TTF fonts on which computer?
And under which glyphsapp version?
Thanks.

Answer 7 · 2017-03-22T13:12:47.000Z

@m4rc1e @alexeiva
Done and ready to be prepped and pushed from my point of view.
Yoohoo!

Answer 8 · 2017-03-22T13:21:37.000Z

Cheers folks

…

On 22 March 2017 at 13:12, FAlthausen ***@***.***> wrote: @m4rc1e <https://github.com/m4rc1e> @alexeiva <https://github.com/alexeiva> Done and ready to be prepped and pushed from my point of view. Yoohoo! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHLUiKl9VXlcR_rj7QBDgG6cT9YvR2WJks5roR5QgaJpZM4MRNrj> .

-- Marc Foley

Answer 9 · 2017-03-23T20:26:54.000Z

@m4rc1e
• Is it correct to leave the linkStyle value empty?
Will it work? Where would it not work with linkStyle=Regular?
• What’s about the SC styles? You deactivated them and didn’t generate fonts of them.

Answer 10 · 2017-03-24T11:05:21.000Z

@FAlthausen

Is it correct to leave the linkStyle value empty?
Yes, it matches our spec. Here's our naming example repo:
https://github.com/davelab6/glyphs-export

If I look at both glyph sources, Vollkorn matches

What’s about the SC styles? You deactivated them and didn’t generate fonts of them.
Your last commit in the repo didn't have them generated either. I made an assumption with this and thought they were wip. I can easily regen them for you?

Answer 11 · 2017-03-24T13:43:55.000Z

What’s about the SC styles? You deactivated them and didn’t generate fonts of them.

Your last commit in the repo didn't have them generated either. I made an assumption with this and thought they were wip. I can easily regen them for you?

Yes, please regenerate them for me!
(You will find the RenameGlyphs export filter weirdly broken in the recent glyphs beta (998). We need to find a stable version to get proper results. I was talking to Georg, but this topic takes time. Additionally, after fixing that the filter might work different? )

Answer 12 · 2017-03-24T16:18:58.000Z

@FAlthausen with the latest version of Glyphs, Version 2.4.2 (998) I can't generate the SC and OT family variants.

Shall I just upload the Roman in the meantime or shall we wait?

cc @davelab6 @schriftgestalt

Answer 13 · 2017-03-24T16:49:31.000Z

What is the error?

Answer 14 · 2017-03-24T16:51:11.000Z

Glyphsapp spends an infinite amount of time trying to generate the SC and OT versions.

Answer 15 · 2017-03-24T16:53:40.000Z

Yikes! No error message? :(

Did you file an issue on the glyphs bug tracker?

Answer 16 · 2017-03-24T17:14:47.000Z

I think this may be a regression issue in Glyphs. I have the feeling they were able to generate just fine in the past.

…

On 24 March 2017 at 16:53, Dave Crossland ***@***.***> wrote: Yikes! No error message? :( Did you file an issue on the glyphs bug tracker? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHLUiG7YWXE1PmgXrfFyBJQ3NwLuOdw0ks5ro_UVgaJpZM4MRNrj> .

-- Marc Foley

Answer 17 · 2017-03-24T17:45:12.000Z

Georg and I were testing and messing around with this feature in the past. Unfortunately in the recent version it doesn't work at all. I built a test case for him. Now let's see when he will find time to fix it. I tried an old version on my computer (966), which does it nearly right …
The OT instances are not for Google Fonts but are already published on vollkorn-typeface.com.
I suggest waiting. Without knowing how long Georg will need. Because SC are the main improvement of Vollkorn 4.0.

Answer 18 · 2017-03-24T20:07:32.000Z

I'm on it.

Answer 19 · 2017-03-24T22:23:55.000Z

I finally had a look at your test. They should work now and also the VollkornSC fonts should export correctly. Please try with this version:
https://updates.glyphsapp.com/Glyphs2.4.2-999.zip

Answer 20 · 2017-03-25T06:54:39.000Z

@schriftgestalt Großartig, Georg! I will be able to test that tonight.
@m4rc1e If you can do it earlier, go ahead!

Answer 21 · 2017-03-27T09:17:34.000Z

@schriftgestalt The substitutions look nice, but I found a bug: turned components got shifted some units downwards. Please use [this-repo]/sources/vollkorn.glyphs for testing.

Answer 22 · 2017-03-28T11:55:45.000Z

I forgot to upload the screenshot of the bug:

Answer 23 · 2017-03-28T20:29:58.000Z

I just uploaded a cutting edge version that should fix this.

Answer 24 · 2017-03-29T13:59:47.000Z

@m4rc1e I committed the final correction inclusive generated SC fonts.
Please push it online now!