Review Lab2 - Krzysztof Kleist
KrzysztofKleist opened this issue · 1 comments
Review Lab2
First thing - you provided a clear explanation of GA using your backpack example in genetic_algorithm_from_scratch folder. With the visualizations it makes it very easy to understand how the algorithm works.
You also took one step further and got some knowledge about GA outside of the classroom that should be appreciated.
Implementation
Another thing that struck me at the beginning is that you checked if the created universe covers the problem - something that at first might seem obvious, but at the end it's good to make sure that the problem is solvable. You also checked if the problem is covered in the algorithm.
There is one issue I'd like to mention. Although you explained clearly how the algorithm works (both by backpack example and pseudocode in README.md) the results are not easy to interpret. Consider adding a final table with results.
Apart from that the solution is unique and very interesting.
Thank you! Yeah, I should add a table result. I will add it in these days!