FEniCS/basix

Copying into column major storage no longer needed

Closed this issue · 1 comments

In these lines:

xt::xtensor<double, 2> B_cmajor({wcoeffs.shape(0), wcoeffs.shape(1)});
B_cmajor.assign(wcoeffs);

wcoeffs used to be copied into column major storage. But now that we no longer use xtensor linalg, this copy is probably no longer needed

Agree, specially because we already copy into a column major matrix before calling Lapack.

basix/cpp/basix/math.cpp

Lines 71 to 75 in 201f0ea

xt::xtensor<double, 2, xt::layout_type::column_major> _A(A.shape());
_A.assign(A);
xt::xarray<double, xt::layout_type::column_major> _B(B.shape());
_B.assign(B);