Windows no longer compiles

Question

Windows no longer compiles

FGasper opened this issue 2 years ago · 10 comments

libnfs appears, in sahlberg/libnfs@028cff9, to have broken this module on Windows.

I’m unsure of the fix presently. While libnfs itself builds on Windows, its internal writev implementation doesn’t seem to work for this module.

Answer 1 · 2022-12-01T16:35:12.000Z

I’ve tried setting that implementation to be non-inline, but that didn’t fix the situation. I either see “missing symbol”, or multiple-definition errors, for writev.

Answer 2 · 2022-12-01T17:13:10.000Z

@rovo89, do you have any insight here?

Answer 3 · 2022-12-01T18:51:10.000Z

Unfortunately I don't have a test environment, so I can just check the actions... I assume the latest one is this:
https://github.com/FGasper/p5-Net-LibNFS/actions/runs/3593949367/jobs/6051579223

And there the error is:

libnfs.xs: In function '_set_unix_authn':
libnfs.xs:806:78: error: expected ')' before 'PRIu32'
  806 |     if (value > UINT32_MAX) croak("%s: value (%" UVuf ") exceeds maximum (%" PRIu32 ")", name, value, UINT32_MAX);
      |                                  ~                                           ^~~~~~
libnfs.xs:806:78: note: in definition of macro '_croak_if_uv_exceeds_u32'
  806 |     if (value > UINT32_MAX) croak("%s: value (%" UVuf ") exceeds maximum (%" PRIu32 ")", name, value, UINT32_MAX);
      |                                                                              ^~~~~~
libnfs.xs:31:1: note: 'PRIu32' is defined in header '<inttypes.h>'; did you forget to '#include <inttypes.h>'?
   30 | #include <fcntl.h>
  +++ |+#include <inttypes.h>

Maybe try the suggestion, or maybe use UVuf instead of PRIu32? I don't know the definition, but if it can represent value, then it should be able to represent the smaller UINT32_MAX as well.

Answer 4 · 2022-12-01T18:54:40.000Z

Oof, that’s another issue, but at least probably an easy one to accommodate.

Answer 5 · 2022-12-01T18:59:53.000Z

The “real” problem is writev and readv, which don’t exist in Windows-land. libnfs builds in Windows just fine, but when I try to link libnfs.a into Net::LibNFS I get the linker error that writev and readv don’t exist.

Answer 6 · 2022-12-01T19:28:23.000Z

Difficult... are we even sure that win32_compat.h is included? Maybe https://github.com/marketplace/actions/debugging-with-ssh helps to debug this on the runner itself?

Answer 7 · 2022-12-01T19:33:04.000Z

Notwithstanding the love that that action inspires in me (!!) …

Answer 8 · 2022-12-01T19:52:06.000Z

I think I can get access to a Windows VM; hopefully that’ll yield some answers.

Answer 9 · 2022-12-02T01:49:27.000Z

@rovo89 This seems to do it: https://github.com/sahlberg/libnfs/pull/411/files

Answer 10 · 2022-12-11T17:51:48.000Z

Fixed via update to libnfs.