FHIR/fhir.js

Remove phantomjs

jjosef opened this issue · 5 comments

jjosef commented

PhantomJS is no longer in development, and should be using Chrome/Firefox Headless for testing.

mike1pol commented

I'am already work on this

jjosef commented

Great! I would be happy to contribute this as well since I've done this already for many projects

mike1pol commented

Awesome!
Can you create PR?

jjosef commented

Sure, do you guys have a preference for on which browser it integrates with?

jjosef commented

Here is the PR: #124

The integration tests seem to be failing on the current code-base to begin with. it works fine, and then starts to time out

20 09 2018 12:25:51.729:INFO [karma]: Karma v3.0.0 server started at http://0.0.0.0:9876/
20 09 2018 12:25:51.732:INFO [launcher]: Launching browser ChromiumNoSecurity with unlimited concurrency
20 09 2018 12:25:51.740:INFO [launcher]: Starting browser ChromiumHeadless
20 09 2018 12:25:52.203:INFO [HeadlessChrome 0.0.0 (Mac OS X 10.13.6)]: Connected on socket Z6ynSiAPi_Nsx2-YAAAA with id 7065119
HeadlessChrome 0.0.0 (Mac OS X 10.13.6) angular search FAILED
	Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
LOG: 'angular SPEC'
LOG: 'Step [pt]: start'
LOG: 'Step [pt]: complete'
LOG: 'Step [createPt]: start'
HeadlessChrome 0.0.0 (Mac OS X 10.13.6) angular CRUD FAILED
	Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
HeadlessChrome 0.0.0 (Mac OS X 10.13.6) jquery search FAILED
	Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
LOG: 'jquery SPEC'
LOG: 'Step [pt]: start'
LOG: 'Step [pt]: complete'
LOG: 'Step [createPt]: start'
HeadlessChrome 0.0.0 (Mac OS X 10.13.6) jquery CRUD FAILED
	Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
HeadlessChrome 0.0.0 (Mac OS X 10.13.6) native search FAILED
	Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
LOG: 'native SPEC'
HeadlessChrome 0.0.0 (Mac OS X 10.13.6) native CRUD FAILED
	TypeError: q.defer is not a function
	    at integration_test/nativeSpec.coffee:2812:16
	    at Context.<anonymous> (integration_test/nativeSpec.coffee:2794:15)
HeadlessChrome 0.0.0 (Mac OS X 10.13.6) yui search FAILED
	Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
LOG: 'yui SPEC'
LOG: 'Step [pt]: start'
LOG: 'Step [pt]: complete'
LOG: 'Step [createPt]: start'
HeadlessChrome 0.0.0 (Mac OS X 10.13.6) yui CRUD FAILED
	Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
HeadlessChrome 0.0.0 (Mac OS X 10.13.6): Executed 83 of 83 (8 FAILED) (1 min 10.184 secs / 1 min 10.077 secs)
TOTAL: 8 FAILED, 75 SUCCESS