Count is saved even when params are missing
Opened this issue · 3 comments
manuelmeurer commented
I noticed that a count is saved in Redis even if one or more of the required parameters are missing.
For example:
voncount.config:
{
"foo": {
"bar": [
{
"id": [
"my_param",
"year",
"month",
"day"
],
"count": "baz"
}
]
}
}
Even if I leave out my_param
from my request (/foo
), a count is saved (bar_2014_08_23
).
Wouldn't it make sense to not count anything unless all params are present?
manuelmeurer commented
Ping! 😸
Ronsho commented
Hey Manuel,
It does make sense not to count when a param is missing. We are aware of this issue but we didn't have the time to handle it.
manuelmeurer commented
Ok, cool, just wanted to hear your opinion about it. I will put it on the list of stuff I plan to implement in my fork. 😄