queryForSlaves() does not filter out the unavailable slaves

Question

queryForSlaves() does not filter out the unavailable slaves

yudecheng opened this issue 7 years ago · 4 comments

If one of the slaves stops, the query results of command “SENTINEL slaves master_name“ will also contain the stopped slave. We can filter out these unavailable slaves according to the “flags” field.
The “flags” of the unavailable slave contains "disconnected" or "s_down".

Answer 1 · 2017-07-21T06:37:13.000Z

I am sorry that close this issue by mistake.

Answer 2 · 2017-08-04T12:23:25.000Z

@yudecheng thanks for your report and suggested fix, I'll come up with backwards compatible pull request very soon.

Answer 3 · 2017-08-04T13:01:18.000Z

@yudecheng please look at #3 - is it ok? I think it's pretty reasonable approach which we can extend in future.

Answer 4 · 2017-08-06T04:52:55.000Z

Busy with work recently, has not replied for you in time, I am sorry. I read this modification just now. I think it is very elegant. Thank you very much. 2017-08-06 12:51 GMT+08:00 余德成 <yudechengscut@gmail.com>:

…

Busy with work recently, has not replied for you in time, I am sorry.I read this modification just now 2017-08-04 21:01 GMT+08:00 Alexandr Emelin ***@***.***>: > @yudecheng <https://github.com/yudecheng> please look at #3 > <#3> - is it ok? I think it's > pretty reasonable approach which we can extend in future. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#2 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AYJFFs3AE5u-JlYa99slxR-3djtPFv-xks5sUxYegaJpZM4Oe_z-> > . >