FabricMC/yarn

`AbstractDonkeyEntity` is misleading

NebelNidas opened this issue · 0 comments

It's extended by four classes:

  • DonkeyEntity,
  • LlamaEntity,
  • TraderLlamaEntity and
  • MuleEntity.

The class itself extends from AbstractHorseEntity, which has an additional set of implementers:

  • Horse
  • Skeleton Horse
  • Zombie Horse
  • Camel

My suggestions:

  • AbstractHorseEntity -> HorseLikeEntity
  • AbstractDonkeyEntity -> ChestCarryingHorseLikeEntity (the entire purpose of the subclass is to manage the chest's inventory data)

To be fair, the Like sounds a bit weird, even though it better communicates the purpose.