Release name pattern change causes dynamic downloads to fail
Closed this issue · 0 comments
What happened?
The latest release name was changed from major.minor.patch
({0-9}.{0-9}.{0-9}) to v major.minor.patch
(v {0-9}.{0-9}.{0-9}). This pattern change breaks automatic generated download url and therefore is failing the download of the release files.
Download url with 3.6.1:
https://github.com/FairwindsOps/nova/releases/download/3.6.1/nova_3.6.1_linux_amd64.tar.gz
Download url with v3.6.2:
https://github.com/FairwindsOps/nova/releases/download/v3.6.2/nova_3.6.2_linux_amd64.tar.gz
What did you expect to happen?
In the past the release name pattern was major.minor.patch
. Therefore, I assume that this happened by mistake. I would expect that if the release name is changed then this would be communicated in the release note. One of the following options can be implemented to fix this issue:
- rename latest release to
major.minor.patch
(removev
) - rename release files by adding the
v
to all file names to have a consistent release name pattern (for example: nova_v
3.6.2_linux_amd64.tar.gz) - use new release name from now on for future release names and communicate in release notes that this pattern will be used from now on
I'm created this bug in case someone else also discovered this issue. It's not a big deal and can be easily changed by the consumer. However, it would be great to know if this is a permanent change so that it will not break again if the next release is named without v
.
How can we reproduce this?
I'm using dynamic generated download url to nightly build an ubuntu docker image with nova. Enclosed you find the code to reproduce the dynamic url:
NOVA_VERSION=$(curl -L https://api.github.com/repos/FairwindsOps/nova/releases/latest | jq .name -r)
echo ${NOVA_VERSION}
echo "download url: https://github.com/FairwindsOps/nova/releases/download/${NOVA_VERSION}/nova_${NOVA_VERSION}_$(uname -s)_amd64.tar.gz"
(click on download url will result in not found
error message)
Version
v3.6.2
Search
- I did search for other open and closed issues before opening this.
Code of Conduct
- I agree to follow this project's Code of Conduct
Additional context
No response