Improper information returning from getSpouses() request on a person.

The following example request sequence is returning improper information:

FamilySearchSDK.getPerson(pid) - Makes the request. On successful fulfillment of the request:
response.getSpouses() - should return the spouses for the returned individual (as per the SDK documentation. Instead, it seems to be returning all of the person's spouses, their father, and (most of) their male children.

Supposedly this reflects a change in the FamilySearch API release that occurred in December that has not yet been accounted for. The bug is interfering terribly with at least one partner app (virtual-pedigree.fhtl.byu.edu).

Calvin McMurray
BYU Family History Technology Lab
fhtlab@gmail.com

@calvinMcM

Thanks for the bug report. We will get this fixed, however I can't give you an estimate on when we will release a new version of the SDK.

FYI: The bug is on the following line if you want to quickly fix it yourself.

familysearch-javascript-sdk/src/modules/persons.js

Line 205 in f729e58

    
           return r.getHusbandId() && r.getWifeId(); // only consider couple relationships with both spouses

@calvinMcM Could you provide me with a sample PID that this bug occurs with?

@calvinMcM Also, which version of the SDK are you using?

The problem exists using my PIC KWFK-99P. As for SDK version, we are currently using version 2.8.2

…

On Jan 4, 2017 3:38 PM, "Justin" ***@***.***> wrote: @calvinMcM <https://github.com/calvinMcM> Also, which version of the SDK are you using? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#175 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH7-EvGHoTFNOWIY7zD7CPcQnIboH5QUks5rPB9HgaJpZM4LVHQG> .

I can't access your PID because you're living and therefore your profile is private. Do you have an example of a deceased person?

MFYR-RQD should have 3 spouses, but we're getting 5 spouses (2 are his father).

Ann
Ann
John Crundall
John Crondall
Ann Osborne

(ignore the duplication)

LHG7-2BQ is the pid for one of my deceasedfemale ancestors. She has a known father and at least one son to help illustrate the point.

…

On Jan 9, 2017 8:43 AM, "Justin" ***@***.***> wrote: I can't access your PID because you're living and therefore your profile is private. Do you have an example of a deceased person? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#175 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH7-Ej7Z7M0MsMPvjsKivqoR9uzghJj1ks5rQlW6gaJpZM4LVHQG> .

@jimmyz @calvinMcM You must be using the relatives parameter. Is that correct? It appears to be adding extra relationships in the response which breaks assumptions made by the code. I didn't know the relatives parameter did that which is why it took so long for me to verify what you were seeing.

This is fixed in v2.10.0

From what I can see, v2.10.0 isn't supported via CDN - it only ships as a NodeJS module. If so, it would only be useful if all of the requests to FamilySearch are being made from the server instead of from client-side code - which is how Virtual Pedigree uses it (as well as several other apps I know of). If the problem has already been resolved in 2.10.0, would it be possible to get that version released through your regular CDN's to allow clients to make use of the updated version?

I left a note on Github about a CDN release of the 2.10.0 version of the SDK. In the interim, were working on building the node moduleseparately and using that. Thanks for all of your help!

…

On Jan 10, 2017 12:53 PM, "Justin" ***@***.***> wrote: This is fixed in v2.10.0 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#175 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH7-EuwnNnoUb15Y5dUjAHdkJ9OmtG59ks5rQ-GrgaJpZM4LVHQG> .

https://unpkg.com/familysearch-javascript-sdk@2.10.0/dist/familysearch-javascript-sdk.min.js

Thanks. That should make things easier. Did I just miss the link to that somewhere?

…

On Jan 11, 2017 7:55 AM, "Justin" ***@***.***> wrote: ***@***.***/dist/familysearch- javascript-sdk.min.js — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#175 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH7-Equ0icxXNKmKevXwOdqs8s3qtsvrks5rRO1ngaJpZM4LVHQG> .

It's in the README.