FasterXML/jackson-core

Migrate remaining test to JUnit 5

timo-a opened this issue · 3 comments

timo-a commented

Since this is going to take several PRs, this issue is intended to coordinate them.

original PR: #1237

  • Part 1: #1238 tests that don't extend or depend on BaseTest or its child classes
  • Part 2: #1244 tests that extend AsyncTestBase
  • Part 3: #1245 tests in core.read that extend BaseTest
  • Part 4 #1246 core.io, core.json and failing
  • Part 5 #1247 core.base64 to core.sym
  • Part 6 #1248 remaining tests
cowtowncoder commented

First PR merged; looks like there are 125 cases of BaseTest being extended so likely target count.

May need 3 - 5 PRs depending on what works best. Since 2.18 branch only now starting, ok to target against 2.17.

timo-a commented

I guess we're done here, junit-vintage-engine is gone from the pom files of master, 2.17 and 2.28.

  • 🎉1
cowtowncoder commented

Indeed! Thank you for doing this, @timo-a !