FenPhoenix/AngelLoader

Exceptions that matter should be reported (fail-early)

FenPhoenix opened this issue · 0 comments

We have far too many places where we just swallow and log exceptions and then move on like nothing happened. We should stop kidding ourselves and inform the user of important errors.

  • Core
    • Init()
    • OpenSettings()
    • SetGameDataFromDisk()
    • RefreshFMsListFromDisk()
    • AddDML()
    • RemoveDML()
    • GetDMLFiles()
    • OpenFMFolder()
    • OpenWebSearchUrl()
    • ViewHTMLReadme()
    • OpenHelpFile()
    • OpenLink()
    • EnvironmentExitDoShutdownTasks()
    • DoShutdownTasks()
    • Shutdown()
  • FindFMs
  • Scanner
  • Game config files
  • FMData.ini
  • Config.ini
  • Install/uninstall/play
    • Pre-checks before install and uninstall
    • Failed installs (error dialog and cleanup)
      • Failed cleanup of failed or canceled install
    • Failed generation of missing missflag.str
    • Failed to write stub comm file
    • Failed to start exe
    • Check for used .mis files
    • Check if OldDark
    • Check if palette fix required
  • Backup/restore
    • Backup
    • Restore
  • Cache
  • Import
  • Audio conversion
  • FMLanguages
  • FFmpeg.NET.Engine
  • Settings window
  • Mods list read fail
  • FM languages read fail

[add others here]