Feu-Secret/Tokenmagic

[BUG] TMFX breaks/cancels all light underneath overlapping overhead tiles

Opened this issue · 6 comments

baileywick commented

Module Version:
v0.6.1.2

Before open any issue
console errors attached. console-errors-1665100226981.log

Describe the bug
Whenever there are two overhead tiles in a scene, and those tiles are overlapping in any way, all lighting under or above the overlap is rendered inert. This only happens when TMFX is enabled and active in the world. No other modules active.

To Reproduce

  1. create two overhead tiles in a scene. Overlap them any way you like.
  2. put a light under or near the overlapping area of the tiles
  3. place a token under the overlapping area of the tiles
  4. you will see that the light does not render around the token

Expected behavior
Expecting to see lights shine properly in a scene with overlapping overhead tiles.

Screenshots

Overhead Tile Configuration
over-tile-configuration

Expected
expected

Actual/Bug
actual

Browser:
Brave (Chromium)

Foundry Version:
v10 build 287

Game System:
dnd5e

Additional context
This prevents the ability to use TMFX in any scene with multiple overhead tiles, including Levels-enabled scenes that have multiple overhead tiles required to constitute a building.

fvtt-Scene-tmfx-troubleshoot.txt
fvtt-Scene-shipyard-prefab-repair.txt

Feu-Secret commented

Thanks for the report. I will investigate it and try to fix it for the next release.

baileywick commented
OsiJr commented

Your error logs indicate you had tiles that were <= 0 width and height? Might be something there.

Do you still have those errors in the console with it now working?

baileywick commented

I'm afraid this bug is back. And I can reproduce it reliably.

PROBLEM:
If there are two overhead tiles that have TMFX filters applied to them, the overlapping area does not allow light to shine. This is specifically when using the following modules:

  • TMFX
  • Levels / Better Roofs / Wall Height
  • Libwrapper

Ripper thinks it's a problem with TMFX.

No console errors.

Scene export is attached, if it helps.

baileywick commented

fvtt-Scene-shipyard-prefab-repair.txt
fvtt-Scene-tmfx-troubleshoot.txt

These are two sample scenes (.json changed to .txt so they would upload). You'll see that scene only has a single TMFX tile, and it still blocks light.

Feu-Secret commented

This problem is related to core. I know how to solve it.