[BUG] Incompatible with Foundry V12
Closed this issue · 20 comments
Module Version: v0.6.7
Before open any issue
- Enable the module setting "Enable debugging"
- Click F12 go to the console tab
- make the test you want and replicate the error
- Go to the tab console open on point 2) and just right click and click 'Save as' and 'Save' or send a screenshot of the exception on the console.
- Attach the text file on the github issue with all the logs related tot he module, or send a screenshot of the messages on the console.
Describe the bug
You cannot place spell templates anymore.
To Reproduce
Steps to reproduce the behavior:
- Create an actor
- Assign a spell with a template
- Cast it and try to place template
Expected behavior
To be able to place Spell Templates
Screenshots
If applicable, add screenshots to help explain your problem.
Browser:
Foundry Version: V12
Game System: System: DnD 5e 3.2.0
Additional context
Add any other context (like other modules installed) about the problem here.
This works if you use the "Override" setting.
For example, if I put a specific spell - Fireball - and then place a template of this spell - everything works.
When auto-defining the module lost the names of the template types and instead specifies them as [object Object].
Still experiencing this issue. Tried the override setting but still am receiving the same error when attempting to place the template.
Also tried reloading the module and reimporting and recreating the spell.
Seems others are experiencing this issue as well: https://www.reddit.com/r/FoundryVTT/comments/1dd47xv/5e_failed_to_place_measured_template/
I am pretty sure I have fixed version somewhere, so I will make an update to the module!
I am pretty sure I have fixed version somewhere, so I will make an update to the module!
There is a fix for this tokenmagic/module/autoTemplate/dnd5e.js
line 175
for (const [_, dmgType] of item.system.damage.parts) {
dmgSettings = categories[dmgType] || {};
config = dmgSettings[template.document.t];
data.data.... to item.system.damage.parts
template.data.t to template.document.t
Even better, if you could make a PR I will merge it today
Hi, has this gone in? Were should we expect an update? or is there something that i could do to circumvent the issue in my current games?
Judging from the latest release, it looks like you've added v12 support but you didn't update the module.json file and you haven't pushed a release in the packages tool.
Effects applied by macros using this module sometimes don't take effect until after a browser refresh (I tried Chrome and Edge).
This module also seems to interfere with or even disable animations applied by Automated Animatons and Sequencer too.
The change log mentions a D&D update last week. Please consider a PF2E and Foundry v12 update soon.
Thanks for making this awesome module! It's great, and I am a heavy user. I especially love the token drop shadow effect macros!
System PF2E, Foundry v12
Please remember that while I can make patches I am just a contributor - I do not have release privileges on Foundry side. I am not the module maintainer too - so if you have PRs I will gladly accept them and merge them into the package.
I would be keen on seeing V12 compatibility wrapped up, enough where I'd like to put a $150 bounty it working. I'll also pay $25 to the owner or whoever has perms on a V12 release.
I can confirm v0.6.8 works on V12, you can send the bounty to @IsendurHun I guess :D (see commit 1c86b70)
That said the owner said they are no longer maintaining the module, as they are now part of the Foundry staff, and are looking for maintainers, so until someone takes the mantle (or any future Foundry release merges this plugin) the only option is download and install 0.6.8 manually
@IsendurHun if you're wanting to accept the bounty, could you reach out to me on Discord (khionu) or email (see GH profile)? Can coordinate privately.
Thank you very much!
I can confirm v0.6.8 works on V12, you can send the bounty to @IsendurHun I guess :D (see commit 1c86b70)
That said the owner said they are no longer maintaining the module, as they are now part of the Foundry staff, and are looking for maintainers, so until someone takes the mantle (or any future Foundry release merges this plugin) the only option is download and install 0.6.8 manually
How would one go about installing it manually? I tried just downloading and extracting the tokenmagic.zip into the folder in foundry but the bug where it can't see the damage type is still there.
Ah that, I think it's still there, when I said it worked I referred to the bug where it couldn't place the template in any way. On a wild guess, [object Object] is likely a minor issue to fix, maybe I'll give it a shot on some spare time.
I don't have it on a locally built version so likely this has been fixed by #270 and it just needs a new release - @Rughalt could you author one ? I would suggest also npm audit fix since there seems to be a vulnerability pending.
@Tapircurr Until then, if you want to get down and dirty with node
git clone https://github.com/Feu-Secret/Tokenmagic.git
cd Tokenmagic
npm install
npm run build
Then copy everything from the tokenmagic (lowercase) folder where you installed the foundry module (delete old contents from the previous installation first).
Ah that, I think it's still there, when I said it worked I referred to the bug where it couldn't place the template in any way. On a wild guess, [object Object] is likely a minor issue to fix, maybe I'll give it a shot on some spare time.
@Aedif already fixed it, just need new version as you mentioned it
So I have talked with @Feu-Secret and will be taking over the repo and the Foundry package listing and will release updated version as soon as I get both access!
This is the last piece holding me up from V12. Really grateful you're taking the mantle!
Hi! I released new version, if there are any other issues please report them in the new issue so its easier for me to manage!