Fevol/obsidian-criticmarkup

Metadata is not added automatically to ranges when editing in suggestion mode

kinglion580 opened this issue · 4 comments

kinglion580 commented

mode is suggestion:

Metadata is not added automatically to ranges when editing in suggestion mode:
image

add metadata is on:
image

Fevol commented

By all accounts, that combination of settings should result in metadata being added.
Did you also enable "Include Metadata Extension" in the General settings

kinglion580 commented

yes, I enabled "Include Metadata Extension"
image

Fevol commented

Thanks for the quick response! I think I have a general idea as to why this is not working: COMMENTATOR_GLOBAL.PLUGIN_SETTINGS is currently used to generate which metadata should be added

If you are a bit familiar with the dev tools, if you debug in the function: function generate_metadata(), you should be able to find what the value for that object is at that moment. If COMMENTATOR_GLOBAL.PLUGIN_SETTINGS.add_metadata or any of the other add_... settings are false, that should be the issue.

(I've also attached a build that console.log's these values for you:)
commentator.zip