getRequest never called in Model or Collection
throrin19 opened this issue · 4 comments
throrin19 commented
Hello,
I have a problem with the last version of vue-mc : 0.6.0
The method getRequest
is never called in my models and collections and it works fine in 0.5.0.
I use that to set the request informations (baseURL and headers) for all collections/models requests :
import { request } from 'libs/session';
class MyCollections extends Collection {
getRequest(config) {
config.baseURL = request.defaults.baseURL;
config.headers = request.defaults.headers;
return super.getRequest(config);
}
}
It's normal ? I see no informations about this breaking change in the changelog
rtheunissen commented
My apologies @throrin19, I wasn't following semver properly and renamed getRequest
to createRequest
between 0.5 and 0.6, which clearly breaks BC.
rtheunissen commented
I've added that in the changelog now. Will be more thorough in the future. 👍
Kivt commented
Please, edit documentation. At http://vuemc.io/#model-request-custom it still getRequest
rtheunissen commented
Thank you @Kivt, updated.